This repository was archived by the owner on May 17, 2024. It is now read-only.
rudimentary support for --stats in --dbt --json mode#647
Merged
Conversation
* upstream/master: v0.7.14 add debugging detail for VSCode format fix tests add both logical & raw type to schema add dataset schemas to --json output
Contributor
|
@vvkh could you review this? Specifically the changes in format.py? |
vvkh
reviewed
Aug 3, 2023
vvkh
reviewed
Aug 3, 2023
vvkh
suggested changes
Aug 3, 2023
Contributor
vvkh
left a comment
vvkh
left a comment
There was a problem hiding this comment.
@stefankeidel thank you for contribution!
LGTM, let's add a simple test before merge.
Author
|
Apologies for not being particularly responsive, I’m currently on vacation. Should be back early next week. Thanks for taking the time to look at this!On 9. Aug 2023, at 09:41, Dan Lawin ***@***.***> wrote:
@dlawin commented on this pull request.
In data_diff/format.py:
@@ -40,6 +40,7 @@ def jsonify(
dataset2_columns: Columns,
columns_diff: Dict[str, List[str]],
with_summary: bool = False,
+ stats_only: bool = False,
I wasn't able to get the tests to run locally on a M1 mac, sadly. Would be fantastic if there was a dockerised setup one could run end-to-end for that
Looks like they're having trouble running the tests. I can spend some time tomorrow adding one
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
vvkh
approved these changes
Aug 12, 2023
* upstream/master: clarify getting started for dbt vs xdb (#678)
vvkh
approved these changes
Aug 14, 2023
vvkh
suggested changes
Aug 14, 2023
Contributor
vvkh
left a comment
vvkh
left a comment
There was a problem hiding this comment.
hey @stefankeidel, looks like one of the tests is now failing, can you take a look?
Apologies, I only tested the case where --stats is passed.
Author
Yep, sorry. I'm still unable to run the tests locally, which makes verifying without CI/CD a bit hard :). Hopefully good to go now, but let's see. |
vvkh
approved these changes
Aug 14, 2023
Contributor
|
@stefankeidel LGTM now, appreciate the effort 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're working on a ci/cd implementation of data-diff for a dbt project in azure devops and a full diff is just taking too long.
This here change works for my particular case and I was wondering if maybe it's useful for the upstream project as well.
I wasn't able to get the tests to run locally on a M1 mac, sadly. Would be fantastic if there was a dockerised setup one could run end-to-end for that